-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the NPE while post content is null #7321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a bug where a NullPointerException occurs when post content is null by adding a null check and updating the excerpt generation logic.
- Added a test case (shouldGenerateBlankExcerptWhenContentIsNull) to validate that a blank excerpt is generated when content is null.
- Updated PostReconciler.java to return an empty string when either content or raw is blank.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
application/src/test/java/run/halo/app/core/reconciler/PostReconcilerTest.java | Added a test case to cover a null post content scenario |
application/src/main/java/run/halo/app/core/reconciler/PostReconciler.java | Added a guard clause to return an empty excerpt if content values are blank |
Comments suppressed due to low confidence (2)
application/src/main/java/run/halo/app/core/reconciler/PostReconciler.java:391
- The current condition returns an empty excerpt if either 'content' or 'raw' is blank. Confirm if this is the intended logic, or if a non-null value in one should be used to generate the excerpt.
if (StringUtils.isAnyBlank(content.getContent(), content.getRaw())) {
application/src/test/java/run/halo/app/core/reconciler/PostReconcilerTest.java:110
- Consider adding additional test cases for scenarios where only one of 'content' or 'raw' is blank, to ensure the behavior is consistent with the business requirements.
void shouldGenerateBlankExcerptWhenContentIsNull() {
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7321 +/- ##
============================================
+ Coverage 57.18% 57.46% +0.28%
- Complexity 4066 4093 +27
============================================
Files 721 721
Lines 24546 24594 +48
Branches 1612 1621 +9
============================================
+ Hits 14036 14133 +97
+ Misses 9882 9823 -59
- Partials 628 638 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/milestone 2.20.x
What this PR does / why we need it:
This PR fixes the NPE while post content is null. See #7320 for more.
Which issue(s) this PR fixes:
Fixes #7320
Does this PR introduce a user-facing change?