Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NPE while post content is null #7321

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR fixes the NPE while post content is null. See #7320 for more.

Which issue(s) this PR fixes:

Fixes #7320

Does this PR introduce a user-facing change?

修复通过接口创建文章可能导致无法发布和删除的问题

@JohnNiang JohnNiang requested a review from Copilot April 2, 2025 03:17
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Apr 2, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Apr 2, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Apr 2, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG April 2, 2025 03:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a bug where a NullPointerException occurs when post content is null by adding a null check and updating the excerpt generation logic.

  • Added a test case (shouldGenerateBlankExcerptWhenContentIsNull) to validate that a blank excerpt is generated when content is null.
  • Updated PostReconciler.java to return an empty string when either content or raw is blank.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
application/src/test/java/run/halo/app/core/reconciler/PostReconcilerTest.java Added a test case to cover a null post content scenario
application/src/main/java/run/halo/app/core/reconciler/PostReconciler.java Added a guard clause to return an empty excerpt if content values are blank
Comments suppressed due to low confidence (2)

application/src/main/java/run/halo/app/core/reconciler/PostReconciler.java:391

  • The current condition returns an empty excerpt if either 'content' or 'raw' is blank. Confirm if this is the intended logic, or if a non-null value in one should be used to generate the excerpt.
if (StringUtils.isAnyBlank(content.getContent(), content.getRaw())) {

application/src/test/java/run/halo/app/core/reconciler/PostReconcilerTest.java:110

  • Consider adding additional test cases for scenarios where only one of 'content' or 'raw' is blank, to ensure the behavior is consistent with the business requirements.
void shouldGenerateBlankExcerptWhenContentIsNull() {

Copy link

sonarqubecloud bot commented Apr 2, 2025

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.46%. Comparing base (60c2009) to head (540ac90).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7321      +/-   ##
============================================
+ Coverage     57.18%   57.46%   +0.28%     
- Complexity     4066     4093      +27     
============================================
  Files           721      721              
  Lines         24546    24594      +48     
  Branches       1612     1621       +9     
============================================
+ Hits          14036    14133      +97     
+ Misses         9882     9823      -59     
- Partials        628      638      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 2a6bedc into halo-dev:main Apr 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to publish or delete posts when content.content is set to null
2 participants