Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose time validation, issue #12 #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

SagyBle
Copy link
Collaborator

@SagyBle SagyBle commented Apr 18, 2023

Code Reviewer

Related Issue

Please Review

  • [ ]
  1. Choose time inputs are being tested before sent.
  2. Data is sent only after popup confirmation.
  • need to check with product the actual flow happens after confirming the popup. like is there confirmation page afterwards? or is the popup text is correct?


dispatch(
openPopup({
title: "מעולה! פרטייך נשלחו",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

texts here are not correct. should be a text that's asking the user to confirm to post the session request

title: "מעולה! פרטייך נשלחו",
text: "בקרוב ניצור איתך קשר בוואטסאפ ונקשר אותך לשיחה עם אדם עם תחושות שונות בנושא שבחרת",
handleConfirm: () => {
postSessionRequest(session);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
postSessionRequest(session);
try {
await postSessionRequest(session);
// close popup and redirect to a success page (not back to emotions selection)
} catch(error) {
// handle network request error by displaying an error to the user
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants