Skip to content

argocd: Add GPG public key for user import #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drGrove
Copy link
Member

@drGrove drGrove commented Jun 8, 2020

No description provided.

@daurnimator
Copy link
Member

Although this is useful, its sort of a dangling artifact.
Can we find a better place for it?

@drGrove drGrove force-pushed the argocd-deploy-gpg-pub-key branch from cf72d5f to 9fbc669 Compare June 8, 2020 17:47
@drGrove drGrove requested a review from daurnimator June 9, 2020 02:30
@drGrove drGrove force-pushed the argocd-deploy-gpg-pub-key branch 2 times, most recently from 607a6b7 to 4b7e421 Compare June 21, 2020 00:31
@drGrove drGrove force-pushed the argocd-deploy-gpg-pub-key branch from 4b7e421 to b2a69c9 Compare June 21, 2020 00:33
@daurnimator
Copy link
Member

@drGrove see earlier comment:

I like the current setup that each folder in the root is an app. Can we put the key in the argocd folder? or the root?

@drGrove
Copy link
Member Author

drGrove commented Jun 21, 2020

@drGrove see earlier comment:

I like the current setup that each folder in the root is an app. Can we put the key in the argocd folder? or the root?

I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd?

@daurnimator
Copy link
Member

I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd?

idea: what about as an annotation/label on the deploy-key resource itself?

or can we get SOPS to not encrypt a specific field?

@drGrove
Copy link
Member Author

drGrove commented Oct 7, 2020

I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd?

idea: what about as an annotation/label on the deploy-key resource itself?

or can we get SOPS to not encrypt a specific field?

SOPS will only encrypt fields we tell it to. But normally that's data|stringData.
As far as labels/annotations, they have a max limit which I think this would would blow through

@daurnimator daurnimator force-pushed the master branch 2 times, most recently from 2ee34d1 to e9a2b69 Compare December 21, 2020 14:20
@daurnimator daurnimator force-pushed the master branch 4 times, most recently from cab9773 to 3c08261 Compare November 8, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants