Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacks: rename Removed to RemovedComponent in stackeval #36782

Merged
merged 4 commits into from
Apr 1, 2025

Conversation

liamcervante
Copy link
Member

We're going to be supporting removing embedded stacks with a single removed block soon. This PR is refactors the name of Removed into RemovedComponent to help differentiate with the upcoming RemovedStackCall.

@liamcervante liamcervante requested a review from a team as a code owner March 26, 2025 17:00
@liamcervante liamcervante added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Mar 26, 2025
jbardin
jbardin previously approved these changes Mar 28, 2025
Base automatically changed from liamcervante/stacks/prevent-lookups to main April 1, 2025 06:34
@liamcervante liamcervante dismissed jbardin’s stale review April 1, 2025 06:34

The base branch was changed.

@liamcervante liamcervante enabled auto-merge (squash) April 1, 2025 07:07
@liamcervante liamcervante merged commit 9707a27 into main Apr 1, 2025
7 of 8 checks passed
@liamcervante liamcervante deleted the liamcervante/stacks/removed-component-refactor branch April 1, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants