Handle Functor Composition in Generic Instances #1108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at fixing #1059 after #1103 did not cover all cases. First discussion of the approach in #1059 (comment).
Tasks:
GOmitFromJSON
andGOmitToJSON
type classes and instancesS1 s *
instances with single generic implementation based onGOmitFromJSON
andGOmitToJSON
GFromJSON a (f :.: g)
andGToJSON' e a (f :.: g)
recordParseJSONImpl
that now has just a single call siteI would be grateful for feedback by people more knowledgeable about the existing infrastructure than me.