Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Functor Composition in Generic Instances #1108

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

julmb
Copy link

@julmb julmb commented Jun 12, 2024

Second attempt at fixing #1059 after #1103 did not cover all cases. First discussion of the approach in #1059 (comment).

Tasks:

  • add GOmitFromJSON and GOmitToJSON type classes and instances
  • replace S1 s * instances with single generic implementation based on GOmitFromJSON and GOmitToJSON
  • investigate field omission propagation in existing instances GFromJSON a (f :.: g) and GToJSON' e a (f :.: g)
  • inline recordParseJSONImpl that now has just a single call site
  • add regression tests

I would be grateful for feedback by people more knowledgeable about the existing infrastructure than me.

@julmb julmb marked this pull request as ready for review December 19, 2024 12:25
@julmb
Copy link
Author

julmb commented Dec 19, 2024

This PR fixes #1059 (6350e9a, c56cfc1) as well as another issue (c1f6c14) that was present but inaccessible due to the inability to derive instances imvolving (:.:). The regression tests (66d68f5) cover both of these. The remaining commits (0f36b77, 5957128) are cleanup and refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant