Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new functionality delete workflow runs #1331

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joaopjoaquim
Copy link
Contributor

Description

Created new option to soft delete items from the workflow run list. It will delete the related steps and jobs to that particular run.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change (pure documentation change)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking changes to code which doesn't change any behaviour)
  • CI (any automation pipeline changes)
  • Chore (changes which are not directly related to any business logic)
  • Test changes (add, refactor, improve or change a test)
  • This change requires a documentation update

What's Changed

  • Add a list of tasks or features here...

Copy link

vercel bot commented Mar 13, 2025

@joaopjoaquim is attempting to deploy a commit to the Hatchet Team on Vercel.

A member of the Team first needs to authorize it.

@joaopjoaquim joaopjoaquim force-pushed the wsUI branch 2 times, most recently from 5a6de92 to 0ad6ccb Compare March 13, 2025 12:50
@joaopjoaquim
Copy link
Contributor Author

Hello @abelanger5, is there anything that needs to be done to authorize this PR?

@abelanger5
Copy link
Contributor

Hey @joaopjoaquim thanks for this PR!

I think this is great functionality to add -- at the moment we're currently focused on releasing v1 of the engine: #1348.

We'd want to support this on the v1 version, since we're planning to move v0 into maintenance mode shortly. Would you be open to implementing this functionality in the v1 engine instead?

@joaopjoaquim
Copy link
Contributor Author

@abelanger5, yes, I'd love to implement it in the v1 engine. How do I access the v1? Is there a particular branch in which I would need to work on?

@abelanger5
Copy link
Contributor

If you run from the main branch, you'll be able to run on v1. When you checkout the main branch and run task migrate, it should migrate all of the v1 tables onto your local instance. Then when you navigate to the "Tenant Settings" page, you will see an option to migrate to v1:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants