Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for results in csv format #725

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Conversation

jonilaitinen
Copy link

This adds support for outputting the result of each request as CSV line. This is similar as in the -o option in hey load generator though the CSV format here is different.

There is also a new --output-format command line switch which can take values text (default), json or csv. Previous -j / --json flag has been removed to consolidate output selection to use the one --output-format flag. This seemed like a better way to handle multiple output formats instead of adding separate (exclusive) flags for each different output format, but open to suggestions on this if there's a better way to organize the flags, also open to suggestions on the CSV format.

Copy link
Owner

@hatoo hatoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I added a small review.

Joni Laitinen added 2 commits April 7, 2025 10:16
This adds support for outputting the result fo each request as CSV.
This is similar as in the `hey` load generator though the CSV format is slightly different.

There is also a new `--output-format` command line switch which can take values
`text` (default), `json` or `csv`. Previous `-j` / `--json` flag has been removed to consolidate
output selection to use the one `--output-format` flag. This seemd like a better way to handle
multiple output formats instead of adding separate (exclusive) flags for each different output format.
Replaced `.last()` with `.next_back()` as `.last()` will needlessly iterate the whole iterator.
@hatoo hatoo merged commit 4134efa into hatoo:master Apr 7, 2025
18 checks passed
@hatoo
Copy link
Owner

hatoo commented Apr 7, 2025

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants