Skip to content

fix: DialogStack not opening #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dpaulos6
Copy link

@dpaulos6 dpaulos6 commented Mar 23, 2025

Description

Refactor DialogStack components to use TypeScript generics

Related Issues

Related to #93

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if necessary.
  • I have added tests that prove my fix is effective or my feature works.
  • New and existing tests pass locally with my changes.

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • Refactor
    • Improved the consistency and reliability of dialogs, resulting in a smoother and more dependable user experience.

Copy link

vercel bot commented Mar 23, 2025

@dpaulos6 is attempting to deploy a commit to the Hayden Bleasel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented Mar 23, 2025

📝 Walkthrough

Walkthrough

This pull request enhances type safety in the dialog stack components by adding explicit type parameters to ReactElement assertions. The changes update the cloneElement calls in the DialogStackTrigger, DialogStackBody, DialogStackNext, and DialogStackPrevious components to include their respective prop types. Additionally, the assignment of the className property is adjusted to align with the updated type assertions.

Changes

File Changes Summary
packages/dialog-stack/index.tsx Updated cloneElement assertions in DialogStackTrigger, DialogStackBody, DialogStackNext, and DialogStackPrevious to include specific prop types; adjusted className access.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dec3e66 and 96babac.

📒 Files selected for processing (1)
  • packages/dialog-stack/index.tsx (4 hunks)
🔇 Additional comments (4)
packages/dialog-stack/index.tsx (4)

117-122: Improved type safety with generic type parameters

The addition of DialogStackTriggerProps as a type parameter to ReactElement makes the component more type-safe. This will help TypeScript better validate that the children passed to this component have the correct props structure.


216-218: Enhanced type checking for DialogStackBody children

Good improvement by adding the DialogStackChildProps type parameter to the ReactElement assertion. This ensures that each child element has the correct prop types when passing the index.


380-385: Better type safety for DialogStackNext

The use of ReactElement<DialogStackNextProps> properly constrains the children's type, ensuring that props like onClick and className can be safely accessed and modified. This change helps prevent potential type errors during development.


430-435: Consistent type improvements for DialogStackPrevious

This change follows the same pattern as the other components, ensuring type consistency throughout the codebase. Using the specific DialogStackPreviousProps type parameter improves type checking for the component's children.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dpaulos6 dpaulos6 changed the title chore: Refactor DialogStack components to use TypeScript generics fix: DialogStack not opening Mar 23, 2025
@dpaulos6 dpaulos6 marked this pull request as draft March 23, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant