Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tasks/cookie consent and bug fixes #488

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

vivek-codepalette
Copy link

Description

Features

Bugs

  • Blog/:slug in apps/web displays left side instead of being centered.
  • legal/:slug in apps/web displays to the left side instead of being centered
  • / should display en language by default without /en being explicitly added to the params
  • Localization doesn't work when the user goes from /es/blog -> /es/contact. It instead redirects to /en/contact

Features

  • Added cookie consent

Related Issues

Closes #<issue_number>

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if necessary.
  • I have added tests that prove my fix is effective or my feature works.
  • New and existing tests pass locally with my changes.

Screenshots (if applicable)

Additional Notes

Copy link

vercel bot commented Mar 14, 2025

@vivek-codepalette is attempting to deploy a commit to the Hayden Bleasel Team on Vercel.

A member of the Team first needs to authorize it.

@vivek-codepalette vivek-codepalette changed the title Tasks/cookie consent and bug fixes [WIP] Tasks/cookie consent and bug fixes Mar 21, 2025
@haydenbleasel
Copy link
Owner

Hey @vivek-codepalette, thanks for your patience! Reviewing this now.

I can't merge until the changes are reduced - if you undo your commits where you bump deps, I can review them.

@vivek-codepalette
Copy link
Author

@haydenbleasel This is still a draft PR. I'll update the code once dependencies are updated.
Could you merge the dependencies PR?#487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants