Skip to content

Update demos to work with HelloNode #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 11, 2023
Merged

Conversation

hello-chintan
Copy link
Contributor

@hello-chintan hello-chintan commented Aug 9, 2023

This PR makes several changes to the stretch_demos package:

  1. Updates HelloNode class by creating node through the Node class - previously done with rclpy.create_node method
  2. Updates all demos to subclass from the HelloNode class to remove repetitive code
  3. Updates the grasp object demo to work with a DexWrist
  4. Adds instructions to run keyboard teleop in a separate terminal for each demo

To test, follow instructions in the README

Bugs that require further investigation:

  1. Plane detection in the clean surface demo is poor because of poor fill rate from RealSense. The pointcloud feed in the realsense-viewer has a much better fill rate than one generated by the ROS drivers.
  2. The open drawer demo applies too much effort when descending the hook to grab the drawer handle. This is because of the contact threshold bug in the lift. See Fix contact_thresh_neg value for the lift stretch_firmware#22

Copy link
Contributor

@hello-atharva hello-atharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hello-chintan hello-chintan merged commit ceba8cf into iron Aug 11, 2023
@hello-chintan hello-chintan deleted the feature/hellonode_demos branch August 11, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants