Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sq, lq, c_ldq #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ViktoriaGromova
Copy link
Contributor

Hello, @herumi!
This small PR adds sq, lq, c_ldq.
Thank you in advance.

@dannykireev
Copy link
Contributor

Hello, @herumi !
Are you planning to merge this PR. I think this functionality might prove useful.
Could you please review?
Thanks in advance.

@herumi
Copy link
Owner

herumi commented Sep 12, 2023

I have so many tasks, but I am not feeling well. I will do it little by little, so please wait for me.

@herumi
Copy link
Owner

herumi commented Sep 13, 2023

Thank you for the patch. But sq and lq are for RV128, which is working in progress, and riscv64-linux-gnu-as seems not to support those, so I won't append them until it supports them.

% riscv64-linux-gnu-as -march=rv128 a.s
Assembler messages:
Error: rv128: ISA string must begin with rv32 or rv64
a.s:1: Error: unrecognized opcode `lq x3,512(sp)'

% riscv64-linux-gnu-as -v
GNU assembler version 2.40 (riscv64-linux-gnu) using BFD version (GNU Binutils for Ubuntu) 2.40

@dannykireev
Copy link
Contributor

@herumi what about adding them under some ifdef for future use?

@herumi
Copy link
Owner

herumi commented Sep 13, 2023

If the correctness of the code can be verified with Binutils, it is acceptable to add it with ifdef. Do you know of any version to support them?

@dannykireev
Copy link
Contributor

@herumi unfortunately, I couldn't find the proper toolchain to support them. So apparently, we should leave them be, until support is available. Thank you for your feedback!

@herumi
Copy link
Owner

herumi commented Sep 15, 2023

Okay, I'll close this PR now, and will support it later.
By the way, if you have a list of instructions you want, I'll support it step by step. It will reduce the costs that you make a PR and that I check it. How about it?

@dannykireev
Copy link
Contributor

Hello, @herumi. Sorry for long answer. Thank you for your proposition, that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants