-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sq, lq, c_ldq #12
base: main
Are you sure you want to change the base?
Add sq, lq, c_ldq #12
Conversation
Hello, @herumi ! |
I have so many tasks, but I am not feeling well. I will do it little by little, so please wait for me. |
Thank you for the patch. But sq and lq are for RV128, which is working in progress, and riscv64-linux-gnu-as seems not to support those, so I won't append them until it supports them. % riscv64-linux-gnu-as -march=rv128 a.s
Assembler messages:
Error: rv128: ISA string must begin with rv32 or rv64
a.s:1: Error: unrecognized opcode `lq x3,512(sp)'
% riscv64-linux-gnu-as -v
GNU assembler version 2.40 (riscv64-linux-gnu) using BFD version (GNU Binutils for Ubuntu) 2.40 |
@herumi what about adding them under some |
If the correctness of the code can be verified with Binutils, it is acceptable to add it with ifdef. Do you know of any version to support them? |
@herumi unfortunately, I couldn't find the proper toolchain to support them. So apparently, we should leave them be, until support is available. Thank you for your feedback! |
Okay, I'll close this PR now, and will support it later. |
Hello, @herumi. Sorry for long answer. Thank you for your proposition, that sounds good. |
Hello, @herumi!
This small PR adds sq, lq, c_ldq.
Thank you in advance.