Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create additional from/to bytes tests - part 3 #1222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create additional from/to bytes tests - part 3 #1222

wants to merge 1 commit into from

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Jan 17, 2025 •
edited
Loading

Related issue: #1088

@0xivanov
chore: create more tests and fix transactions
4f456c1 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Jan 17, 2025
@0xivanov 0xivanov requested review from a team as code owners January 17, 2025 14:30
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 90.27778% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sdk/system_delete_transaction.go 33.33% 3 Missing and 1 partial ⚠️
sdk/token_create_transaction.go 93.18% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
sdk/schedule_create_transaction.go 94.55% <100.00%> (+0.57%) ⬆️
sdk/token_create_transaction.go 94.30% <93.18%> (-0.41%) ⬇️
sdk/system_delete_transaction.go 71.68% <33.33%> (-3.54%) ⬇️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xivanov 0xivanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xivanov