docs: Add and update test specifications for AccountUpdateTransaction
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
rwalworth
requested review from
thenswan,
SimiHunjan,
0xivanov,
RickyLB,
agadzhalov,
Petyo-Lukanov,
svetoslav-nikol0v and
gsstoykov
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
rwalworth
changed the title
AccountUpdateTransactionAccountUpdateTransaction
rwalworth
added
documentation
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
…ill allow for signing of a keylists and thresholdkeys by the TCK Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
SimiHunjan
approved these changes
May 29, 2024
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
|
@thenswan were there any changes you still requested or could I get an approval to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the test specification for
AccountUpdateTransaction. Tests have been added to test the bounds and ranges ofAccountUpdateTransactionproperties, as well as match the style and guidelines of our test specification files.This PR also adds a
privateKeysreturn value forgenerateKeyforkeyListandthresholdKeytypes. This is useful for signing a transaction with akeyListorthresholdKeytype, as the private keys are needed and were previously unobtainable.Note: This is waiting on changes to be merged in #209.
Related issue(s):
Fixes #207