feat(accountDeleteTransaction): Implement AccountDeleteTransaction E2E tests: TCK
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
rwalworth
requested review from
thenswan,
SimiHunjan,
0xivanov,
RickyLB,
agadzhalov,
Petyo-Lukanov,
svetoslav-nikol0v and
gsstoykov
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
…untdeletetransaction
0xivanov
reviewed
Sep 5, 2024
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
ivaylogarnev-limechain
approved these changes
Sep 9, 2024
rwalworth
deleted the
00223-tck-implement-json-rpc-method-for-accountdeletetransaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the tests documented in test-specfications/crypto-service/accountDeleteTransaction.md. Since some of the work was already done for
AccountDeleteTransactiontests, this reworks those tests to match what is in the test specifications, in addition to adding any new tests. The docs were also updated to mark the tests as implemented.Issues opened in SDKs that encompass the SDK server work should be linked back to the TCK's
AccountDeleteTransactiondevelopment issue (#41) for easy tracking.Related issue(s):
Fixes #223
Checklist