Local master #198
Merged
Local master #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
hnnajh
commented
May 16, 2024
hnnajh
commented
* Convert TestLevelControlCluster to asyncio Remove ZCLReadAttribute and ZCLSend API use from the level control test TestLevelControlCluster and convert to asyncio. * Convert TestReadBasicAttributes to asyncio Remove ZCLReadAttribute API use from basic information cluster test and convert to use asyncio. * Use SendCommand directly in send_zcl_command Avoid using ZCLSend API instead use SendCommand directly in the send_zcl_command helper function. * Convert TestFailsafe to use asyncio/SendCommand Remove ZCLSend API usage and call SendCommand directly. Also convert the test to a test using asyncio. * Convert TestOnOffCluster to use asyncio/SendCommand Remove ZCLSend API usage and call SendCommand directly. Also convert the test to a test using asyncio. * Drop TestResult helper class The class is no longer required. Test results are tested directly. * Fix send_zcl_command argument formatting * Catch exception more specifically * Fix TestWriteBasicAttributes for all cases It seems TestWriteBasicAttributes did not correctly write the attributes. The broad exception handling seems to have hidden this issue even. Make sure the attributes with the correct value get written, and check for unexpected and expected IM errors in the per-attribute results specifically. * Fix TestFailsafe by catching correct exception * Drop unused import
* [Python] Rename CallAsync to CallAsyncWithCallback CallAsync continuously calls a callback function during the wait for the call. Rename the function to reflect that fact. This frees up CallAsync for an asyncio friendly implementation. * [Python] Implement asyncio variant of CallAsync Call Matter SDK in a asyncio friendly way. During posting of the task onto the CHIP mainloop, it makes sure that the asyncio loop is not blocked. * [Python] Use CallAsync where appropriate * Rename AsyncSimpleCallableHandle to AsyncioCallableHandle * Rename CallAsyncWithCallback to CallAsyncWithCompleteCallback Also add a comment that the function needs to be released by registering a callback and setting the complete event. * Add comments about lock
… flow. (project-chip#33470) * [Problem] Authorisation dialogue wasn't disabled when user disabled it from settings [Solution] Put a condition to check if user has authorised it. if not, then dialogue will not be shown. [Test] Tested-by: Lazar Kovacic <kovacic.lazar@gmail.com> * Restyled by google-java-format * Update MatterCommissioningPrompter.java * Restyled by whitespace * Restyled by google-java-format --------- Co-authored-by: osamabb <osamabb@amazon.de> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Lazar Kovacic <kovacic.lazar@gmail.com>
…d safe from buffer overruns. project-chip#33449 (project-chip#33482) * Add tests for Nullable String attribute * Use strcmp instead of strncmp to compare a null-terminated arg
Co-authored-by: Kwangseob Jeong <mydpp@naver.com>
…ct-chip#29728) * [ESP32] Fix build errors when -Wundef compiler flag is enabled * Enable -Wundef for ESP32 * Defining CHIP_SYSTEM_CONFIG_LWIP_PBUF_FROM_CUSTOM_POOL Some platforms do not use the lwip from third_party/lwip and may not have LWIP_PBUF_FROM_CUSTOM_POOLS defined in lwip/opt.h. When building apps with -Wundef cflag enabled, it may fail to find LWIP_PBUF_FROM_CUSTOM_POOLS hence this option. This defaults to LWIP_PBUF_FROM_CUSTOM_POOLS if defined, otherwise 0. * remove includes of <lwip/opt.h> and use <system/SystemConfig.h>
… attributes with Changes Omitted Quality (project-chip#33408) * do not cache attribute values for attributes with Changes Omitted Quality * Restyled by whitespace * Restyled by clang-format * manually address feedback that was previously auto-committed * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
update local master
github-actions
bot
added
examples
tools
platform
darwin
tests
test driver
lib
messaging
shell
controller
app
system
esp32
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.