Support local updates with the same version string #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For development it is sometimes useful to just reuse the same version string but increment the underlying build number (which is the actual version devices typically care about). This change supports multiple local updates with the same version string, and updating to an explicit version by version integer.
marcelveldt
approved these changes
Jan 13, 2025
| logger.info("Local updates found for this device") | ||
| if requested_software_version is None: | ||
| # Use integer version to reliably determine absolute latest version | ||
| versions = filter( |
There was a problem hiding this comment.
A list comprehension is easier to read and faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For development it is sometimes useful to just reuse the same version string but increment the underlying build number (which is the actual version devices typically care about).
This change supports multiple local updates with the same version string, and updating to an explicit version by version integer.