Process the mdns messages semi parallel #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
added
the
maintenance
agners
approved these changes
Feb 7, 2024
|
Adjusted the code a bit to fix the (strangely) failing pytest |
agners
approved these changes
Feb 7, 2024
| if existing := self._mdns_queues.get(name): | ||
| queue = existing[0] | ||
| else: | ||
| # we want mdns messages to be processes sequentially PER NODE but in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the processing of mdns events for operational matter nodes a small bit.
We want to process them in sequential order but at the same time not block processing if one node is just slow to respond or whatever.
This introduces a queue and queue processing task per node (or strictly speaking, mdns name)