Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few small improvements to the linter config #567

Merged
merged 2 commits into from
Feb 21, 2024
Merged

A few small improvements to the linter config #567

merged 2 commits into from
Feb 21, 2024

Conversation

marcelveldt
Copy link
Collaborator

@marcelveldt marcelveldt commented Feb 21, 2024 •
edited
Loading

Address a few small improvements to the linter config, as discussed in #548

  • Disable Ruff TCH001 and TCH003 (requirement to move imports into type checking block)
  • Disable ruff rule EM102 (disallow f strings in log)

@marcelveldt marcelveldt added the ci Improvements or additions to the CI actions label Feb 21, 2024
MartinHjelmare
MartinHjelmare approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 2415d73 into main Feb 21, 2024
4 of 5 checks passed
@MartinHjelmare MartinHjelmare deleted the linter-improvements branch February 21, 2024 11:21
@marcelveldt marcelveldt mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
ci Improvements or additions to the CI actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelveldt @MartinHjelmare