-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip push to main branch check in test workflow push #571
Conversation
I don't think we should do this. Tests should run on main branch too. |
I think we should exclude that hook from pre-commit run on CI instead. |
But then its duplicated ? We never push to main directly (without a PR) because we have protected the branch as well as the pre-commit that prevents it. |
I want to prevent this from happening: |
That sounds good, do you have any idea how ? |
This should work:
|
At least it works locally. |
@MartinHjelmare I have adjusted it - so now it excludes that rule only in the CI action but it will still run locally. Also updated the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Our test workflow should ignore the pre-commit action for push to main if running from CI (but still run locally)