Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements to the operational node discovery using mdns #572

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Some improvements to the operational node discovery using mdns #572

merged 4 commits into from
Feb 22, 2024

Conversation

marcelveldt
Copy link
Collaborator

  • debounce incoming mdns events (as they arrive in bursts, especially when a node is restarting)
  • always handle a ADDED event (as that arrives when a node restarts)
  • ignore update events if the node is known to be still alive
  • simplify the code by removing the overcomplex queue logic

Tested this for a while with both powered and battery powered nodes and its working great.
Its especially a huge improvement for rediscovering battery powered nodes.

@marcelveldt marcelveldt added bugfix Pull request that fixes a (known) issue/bug maintenance Code (quality) improvement or small enhancement which not a new feature labels Feb 22, 2024
@marcelveldt marcelveldt merged commit 95973c9 into main Feb 22, 2024
4 checks passed
@marcelveldt marcelveldt deleted the mdns-fixes branch February 22, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix Pull request that fixes a (known) issue/bug maintenance Code (quality) improvement or small enhancement which not a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelveldt @MartinHjelmare