Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tilt Pi icons #6667

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

michaelheyman
Copy link

@michaelheyman michaelheyman commented Mar 4, 2025

Proposed change

Adds Tilt Pi icons for new integration. These are very similar to the existing Tilt Hydrometer icons, but slightly different.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@michaelheyman michaelheyman marked this pull request as ready for review March 4, 2025 04:37
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Mar 4, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These icons seems to differ from their website:

CleanShot 2025-03-04 at 19 53 50

Above all they seem to violate the branding guidelines of Raspberry Pi:

https://www.raspberrypi.com/trademark-rules/

Please adjust the branding.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft March 4, 2025 18:55
@home-assistant
Copy link

home-assistant bot commented Mar 4, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@michaelheyman
Copy link
Author

These icons seems to differ from their website:

CleanShot 2025-03-04 at 19 53 50

Above all they seem to violate the branding guidelines of Raspberry Pi:

https://www.raspberrypi.com/trademark-rules/

Please adjust the branding.

../Frenck

Thanks for the feedback! My intention was to differentiate the icons from the Tilt Hydrometer BLE integration, but I hadn't come across the trademark rules you surfaced.

I have updated the icons to be match the official icon.

@michaelheyman michaelheyman marked this pull request as ready for review March 4, 2025 19:19
@home-assistant home-assistant bot requested a review from frenck March 4, 2025 19:19
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants