-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tilt Pi icons #6667
base: master
Are you sure you want to change the base?
Add Tilt Pi icons #6667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These icons seems to differ from their website:
Above all they seem to violate the branding guidelines of Raspberry Pi:
https://www.raspberrypi.com/trademark-rules/
Please adjust the branding.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thanks for the feedback! My intention was to differentiate the icons from the Tilt Hydrometer BLE integration, but I hadn't come across the trademark rules you surfaced. I have updated the icons to be match the official icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
Adds Tilt Pi icons for new integration. These are very similar to the existing Tilt Hydrometer icons, but slightly different.
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)