Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aeroflex adjustable bed (https://www.aeroflex.co.il/) #6697

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iddora
Copy link

@iddora iddora commented Mar 8, 2025

Proposed change

I'm working on building an integration for BLE controlled Aeroflex adjustable beds.
Planning to contribute the integration to the Home Assistant project.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @iddora 👋

Thanks for opening a pull request. As this PR is adding a core brand, I was looking for the matching pull request against our core repository. However I wasn't able to locate it. Could you point me to it?

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft March 10, 2025 10:22
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@iddora
Copy link
Author

iddora commented Mar 15, 2025

PR for the core repository has been submitted: home-assistant/core#140696

Thank you!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @iddora 👍

Please adjust the PR description to include that link to the core PR (the template there requests for information...)

That said, the linked PR adds a new core integration, not a core brand. Please use the core_integrations folder instead.

../Frenck

@iddora
Copy link
Author

iddora commented Mar 18, 2025

Thanks for pointing out the incorrect location. Files were moved.

@iddora iddora requested a review from frenck March 18, 2025 09:46
@iddora iddora marked this pull request as ready for review March 18, 2025 16:25
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants