Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: extend config/option flow base strings #37263

Closed
1 task
balloob opened this issue Jun 30, 2020 · 9 comments
Closed
1 task

Translations: extend config/option flow base strings #37263

balloob opened this issue Jun 30, 2020 · 9 comments

Comments

@balloob
Copy link
Member

balloob commented Jun 30, 2020

The problem

We don't cover yet all common base strings. We should introduce more:

  • two factor authentication strings
  • The fields pin, name, api_token

Here's the relevant docs section:
https://developers.home-assistant.io/docs/internationalization/core#introducing-new-strings

Related tasks:

  • Use as many references as possible, including in options flow translations

Split out of #34264

Environment

  • Home Assistant Core release with the issue: 112
  • Last working Home Assistant Core release (if known):
  • Operating environment (OS/Container/Supervised/Core):
  • Integration causing this issue:
  • Link to integration documentation on our website:

Problem-relevant configuration.yaml

Traceback/Error logs

Additional information

@djpremier
Copy link
Contributor

djpremier commented Oct 4, 2020

Suggestion unavailable_account, unavailable_service and unavailable_device

@SNoof85
Copy link
Contributor

SNoof85 commented Oct 4, 2020

Forgot to reference to this issue in that already merged PR : #40963

@SNoof85
Copy link
Contributor

SNoof85 commented Oct 5, 2020

https://github.com/search?q=reauth_successful+repo%3Ahome-assistant%2Fcore+filename%3Astrings.json&type=Code&ref=advsearch&l=&l=

Proposal for new common string : "reauth_successful": "Re-authentication was successful"

@balloob
Copy link
Member Author

balloob commented Oct 6, 2020

Sounds good. Want to make a PR for that?

@SNoof85
Copy link
Contributor

SNoof85 commented Oct 6, 2020

Yes, will do :) => Done ! #41316

@SNoof85
Copy link
Contributor

SNoof85 commented Oct 6, 2020

https://github.com/search?q=not_internet_accessible+repo%3Ahome-assistant%2Fcore+filename%3Astrings.json&type=Code&ref=advsearch&l=&l=
Would it be OK to create one for this too ?
"not_internet_accessible": "Your Home Assistant instance needs to be accessible from the internet"
Do we need to handle the integration/service name in the error message ?

@bieniu
Copy link
Member

bieniu commented Oct 6, 2020

Proposal for new common string : "invalid_host": "Invalid hostname or IP address"

https://github.com/search?q=invalid_host+repo%3Ahome-assistant%2Fcore+filename%3Astrings.json&type=Code&ref=advsearch&l=&l=

@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jan 25, 2021
@frenck
Copy link
Member

frenck commented Mar 28, 2025

Most of the strings are now common. New ones are added on a regular basis (merged some today even).

I think we can go ahead an close this one up 👍

../Frenck

@frenck frenck closed this as completed Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants