Add already_in_progress to base strings for config flows #40961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
SNoof85
suggested changes
Oct 1, 2020
|
Thanks @SNoof85 for reviewing all of my PRs! I have fixed the wrong base string, probably a copy-paste error on my side. |
|
As you're faster than me to create i'll do reviews 👀 |
SNoof85
reviewed
Oct 1, 2020
SNoof85
approved these changes
Oct 1, 2020
MartinHjelmare
approved these changes
Oct 1, 2020
homeassistant/strings.json
Outdated
| @@ -51,6 +51,7 @@ | |||
| "already_configured_account": "Account is already configured", | |||
| "already_configured_service": "Service is already configured", | |||
| "already_configured_device": "Device is already configured", | |||
| "already_in_progress": "Config flow is already in progress", | |||
There was a problem hiding this comment.
We (a Lokalise admin) should rename this key in existing translations in Lokalise.
21 tasks
SNoof85
reviewed
Oct 1, 2020
MartinHjelmare
approved these changes
Oct 2, 2020
|
Please rebase again. |
MartinHjelmare
approved these changes
Oct 3, 2020
springstan
deleted the
add-already-in-progress-to-base-strings-for-config-flows
branch
ronanmu
pushed a commit
to ronanmu/home-assistant
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Adds
already_in_progressto the base strings for config flows.Uses this newly added base string in various integrations.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: