-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ZHA thermostat local temperature calibration range for Sonoff TRVZB #109691
Extend ZHA thermostat local temperature calibration range for Sonoff TRVZB #109691
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8f5acc0
to
b0b671a
Compare
b0b671a
to
5b11c6d
Compare
Thanks for the PR! Were you able to successfully set this to a higher value on your Sonoff TRV using the clusters menu? If the Sonoff one supports a higher range, we should probably just change the limits for the Sonoff TRV. |
@TheJulianJES You are probably right. I changed the PR to only change the values for the Edit: I also changed the |
923c423
to
c36d3cb
Compare
504685b
to
ada2232
Compare
fb2d513
to
b2acf2c
Compare
b02e4e2
to
03ab73b
Compare
b09989c
to
a104083
Compare
d26d861
to
de8f603
Compare
Breaking change
This should not break anything. The PR just increases the range and nothing else changes for the entity.
Proposed change
This PR extends the range of
local_temperature_calibration
from-2.5 °C - +2.5 °C
degrees to-7 °C - +7 °C
. The temperature sensor can be way more off than 2.5 degrees. For example, currently my temperature sensor of my TRVZB is 4.6 degrees off. This makes the calibration slider not usable at the moment.Type of change
Additional information
Values are taken from https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/sonoff.ts#L540
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: