-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve type hints in icloud config flow #124900
Conversation
Hey there @Quentame, @nzapponi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
async def _show_verification_code_form( | ||
self, errors: dict[str, str] | None = None | ||
) -> ConfigFlowResult: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user_input
was always None
, and never used, so I removed the argument.
"""Show the trusted_device form to the user.""" | ||
|
||
return self.async_show_form( | ||
step_id=CONF_TRUSTED_DEVICE, | ||
step_id="trusted_device", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it confusing to use the same constant for a config setting and for a step_id.
I have moved the step_id
to be a regular string instead.
Proposed change
SSIA, linked to #124316
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: