Migrate wolflink config_entry unique_id to string #125653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: wolflink
small-pr
|
Hey there @adamkrol93, @mtielen, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
19 tasks
joostlek
reviewed
Sep 10, 2024
joostlek
reviewed
Sep 10, 2024
Comment on lines
35
to
49
| if isinstance(entry.unique_id, int): | ||
| hass.config_entries.async_update_entry(entry, unique_id=str(entry.unique_id)) | ||
| device_registry = dr.async_get(hass) | ||
| for device in dr.async_entries_for_config_entry( | ||
| device_registry, entry.entry_id | ||
| ): | ||
| new_identifiers = set() | ||
| for identifier in device.identifiers: | ||
| if identifier[0] == DOMAIN: | ||
| new_identifiers.add((DOMAIN, str(identifier[1]))) | ||
| else: | ||
| new_identifiers.add(identifier) | ||
| device_registry.async_update_device( | ||
| device.id, new_identifiers=new_identifiers | ||
| ) |
There was a problem hiding this comment.
Should we use a minor migration for this?
There was a problem hiding this comment.
Should we use a minor migration for this?
done
joostlek
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA, linked to #125313 and #125602
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: