Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support readonly selectors in config_flows #129456

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
+51 −6
Open

Support readonly selectors in config_flows #129456

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c321d75
Allow disabled selectors in config flows. Show hidden options for his…
karwosts Oct 29, 2024
e5ef581
fix tests
karwosts Oct 29, 2024
9407b78
use optional instead of required
karwosts Oct 29, 2024
a1ce4a5
rename flag to readonly
karwosts Oct 30, 2024
4d3aa45
rename to read_only
karwosts Nov 23, 2024
958d76f
Update to use read_only field as part of selector definition
karwosts Jan 18, 2025
4915f25
lint fix
karwosts Jan 18, 2025
58489d5
Fix test
karwosts Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions homeassistant/components/history_stats/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,17 @@ async def validate_options(
)
DATA_SCHEMA_OPTIONS = vol.Schema(
{
vol.Optional(CONF_ENTITY_ID, description={"readonly": True}): EntitySelector(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See home-assistant/frontend#22592 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to read_only

vol.Optional(CONF_STATE, description={"readonly": True}): TextSelector(
TextSelectorConfig(multiple=True)
),
vol.Optional(CONF_TYPE, description={"readonly": True}): SelectSelector(
SelectSelectorConfig(
options=CONF_TYPE_KEYS,
mode=SelectSelectorMode.DROPDOWN,
translation_key=CONF_TYPE,
)
),
vol.Optional(CONF_START): TemplateSelector(),
vol.Optional(CONF_END): TemplateSelector(),
vol.Optional(CONF_DURATION): DurationSelector(
Expand Down
12 changes: 12 additions & 0 deletions homeassistant/components/history_stats/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,17 @@
"options": {
"description": "Read the documention for further details on how to configure the history stats sensor using these options.",
"data": {
"entity_id": "[%key:component::history_stats::config::step::user::data::entity_id%]",
"state": "[%key:component::history_stats::config::step::user::data::state%]",
"type": "[%key:component::history_stats::config::step::user::data::type%]",
"start": "Start",
"end": "End",
"duration": "Duration"
},
"data_description": {
"entity_id": "[%key:component::history_stats::config::step::user::data_description::entity_id%]",
"state": "[%key:component::history_stats::config::step::user::data_description::state%]",
"type": "[%key:component::history_stats::config::step::user::data_description::type%]",
"start": "When to start the measure (timestamp or datetime). Can be a template.",
"end": "When to stop the measure (timestamp or datetime). Can be a template",
"duration": "Duration of the measure."
Expand All @@ -49,11 +55,17 @@
"init": {
"description": "[%key:component::history_stats::config::step::options::description%]",
"data": {
"entity_id": "[%key:component::history_stats::config::step::user::data::entity_id%]",
"state": "[%key:component::history_stats::config::step::user::data::state%]",
"type": "[%key:component::history_stats::config::step::user::data::type%]",
"start": "[%key:component::history_stats::config::step::options::data::start%]",
"end": "[%key:component::history_stats::config::step::options::data::end%]",
"duration": "[%key:component::history_stats::config::step::options::data::duration%]"
},
"data_description": {
"entity_id": "[%key:component::history_stats::config::step::user::data_description::entity_id%]",
"state": "[%key:component::history_stats::config::step::user::data_description::state%]",
"type": "[%key:component::history_stats::config::step::user::data_description::type%]",
"start": "[%key:component::history_stats::config::step::options::data_description::start%]",
"end": "[%key:component::history_stats::config::step::options::data_description::end%]",
"duration": "[%key:component::history_stats::config::step::options::data_description::duration%]"
Expand Down
5 changes: 4 additions & 1 deletion homeassistant/data_entry_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,10 @@ def add_suggested_values_to_schema(
):
# Copy the marker to not modify the flow schema
new_key = copy.copy(key)
new_key.description = {"suggested_value": suggested_values[key.schema]}
new_key.description = {
**(new_key.description or {}),
"suggested_value": suggested_values[key.schema],
}
schema[new_key] = val
return vol.Schema(schema)

Expand Down
4 changes: 4 additions & 0 deletions homeassistant/helpers/schema_config_entry_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ def _update_and_remove_omitted_optional_keys(
and key.description.get("advanced")
and not self._handler.show_advanced_options
)
and not (
# don't remove readonly keys
key.description and key.description.get("readonly")
)
):
# Key not present, delete keys old value (if present) too
values.pop(key.schema, None)
Expand Down
Loading