-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webhook in switchbot cloud integration #132882
base: dev
Are you sure you want to change the base?
Add webhook in switchbot cloud integration #132882
Conversation
Hey there @SeraphicRav, @laurence-presland, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
c736341
to
cb279da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can hide them in the overflow menu -> hide annotations But it's a good way to add tests anyway |
b55ea32
to
a2b7448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a merge conflict. Also, I do agree that I think tests are almost a must have for a feature like this. WDYT?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
a2b7448
to
eb3bcf1
Compare
Ok, I fix the conflict |
f60516b
to
df14b5f
Compare
df14b5f
to
bcebd16
Compare
3426cc6
to
f430617
Compare
8202779
to
4eb8506
Compare
4eb8506
to
6f895e5
Compare
what's the status on this one? It would be really nice to have webhook support. :) |
Yes, me too! But I don't have much time for add testing 😔 |
I can work on merge on first time |
09e5ae1
to
1024381
Compare
1024381
to
64b4e01
Compare
Proposed change
Add support webhook to switchbot cloud integration
Basically, Switchbot's cloud notifies home assistant via the registered webhook of any status changes.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: