Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook in switchbot cloud integration #132882

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Gigatrappeur
Copy link
Contributor

@Gigatrappeur Gigatrappeur commented Dec 10, 2024

Proposed change

Add support webhook to switchbot cloud integration
Basically, Switchbot's cloud notifies home assistant via the registered webhook of any status changes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @SeraphicRav, @laurence-presland, mind taking a look at this pull request as it has been labeled with an integration (switchbot_cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot_cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot_cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@SeraphicRav SeraphicRav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution !

Could you please add tests, the code is difficult to read without it...
image

@joostlek
Copy link
Member

You can hide them in the overflow menu -> hide annotations

But it's a good way to add tests anyway

@joostlek joostlek marked this pull request as draft December 18, 2024 13:37
@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch 2 times, most recently from b55ea32 to a2b7448 Compare January 14, 2025 20:44
@Gigatrappeur Gigatrappeur marked this pull request as ready for review January 14, 2025 20:44
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict. Also, I do agree that I think tests are almost a must have for a feature like this. WDYT?

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 17, 2025 16:57
@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch from a2b7448 to eb3bcf1 Compare January 17, 2025 20:29
@Gigatrappeur Gigatrappeur marked this pull request as ready for review January 17, 2025 20:29
@Gigatrappeur
Copy link
Contributor Author

Ok, I fix the conflict

@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch 8 times, most recently from f60516b to df14b5f Compare January 20, 2025 12:01
@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch from df14b5f to bcebd16 Compare January 21, 2025 08:22
@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch 2 times, most recently from 3426cc6 to f430617 Compare January 24, 2025 15:12
@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch 4 times, most recently from 8202779 to 4eb8506 Compare January 31, 2025 15:59
@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch from 4eb8506 to 6f895e5 Compare February 1, 2025 10:11
@MartinHjelmare MartinHjelmare changed the title add webhook in switchbot cloud integration Add webhook in switchbot cloud integration Feb 22, 2025
@mrueg
Copy link
Contributor

mrueg commented Mar 25, 2025

what's the status on this one? It would be really nice to have webhook support. :)

@Gigatrappeur
Copy link
Contributor Author

Yes, me too! But I don't have much time for add testing 😔
Si if anyone can help me, I'll be happy 😊

@Gigatrappeur
Copy link
Contributor Author

I can work on merge on first time

@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch 3 times, most recently from 09e5ae1 to 1024381 Compare March 26, 2025 10:47
@Gigatrappeur Gigatrappeur force-pushed the add-webhook-support-switchbot-cloud-integration branch from 1024381 to 64b4e01 Compare March 26, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switchbot_cloud doesn't correctly update the entity status of K10+ mini vacuum when it is cleaning
4 participants