-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tado add proper off state #135480
Tado add proper off state #135480
Conversation
Hey, what's up with this PR? Is it going to be merged soon |
@joostlek mind taking a brief look? It's a bugfix helping users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does Tado show this in the app? As in, if you turn it off, does it automatically reset your target temperature to nothing? How does the frontend handle this?
You can view the behaviour here: #131646 |
* Add proper off state * Remove current temp * Add default frost temp
Breaking change
Proposed change
In accordance as reported, the target and current temperature were set with the same values. This PR mitigates the issue and also properly puts off the target temperature when the HVAC mode is off.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: