Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tado add proper off state #135480

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Tado add proper off state #135480

merged 4 commits into from
Mar 28, 2025

Conversation

erwindouna
Copy link
Contributor

@erwindouna erwindouna commented Jan 12, 2025

Breaking change

Proposed change

In accordance as reported, the target and current temperature were set with the same values. This PR mitigates the issue and also properly puts off the target temperature when the HVAC mode is off.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mdzhigarov
Copy link

Hey, what's up with this PR? Is it going to be merged soon

@erwindouna
Copy link
Contributor Author

@joostlek mind taking a brief look? It's a bugfix helping users.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does Tado show this in the app? As in, if you turn it off, does it automatically reset your target temperature to nothing? How does the frontend handle this?

@erwindouna
Copy link
Contributor Author

How does Tado show this in the app? As in, if you turn it off, does it automatically reset your target temperature to nothing? How does the frontend handle this?

You can view the behaviour here: #131646

@zweckj zweckj marked this pull request as draft February 17, 2025 19:09
@erwindouna erwindouna marked this pull request as ready for review March 19, 2025 21:52
@zweckj zweckj added this to the 2025.4.0 milestone Mar 28, 2025
@zweckj zweckj added the bugfix label Mar 28, 2025
@zweckj zweckj merged commit 1ab5bdf into home-assistant:dev Mar 28, 2025
34 checks passed
@erwindouna erwindouna deleted the tado-off-state branch March 28, 2025 20:13
frenck pushed a commit that referenced this pull request Mar 28, 2025
* Add proper off state

* Remove current temp

* Add default frost temp
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tado integration setpoint temperature and actual temperature the same
5 participants