Update Vesync light state after on / off commands #135958
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: vesync
small-pr
|
Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
reviewed
Jan 19, 2025
|
In the native app? Yes. Without this code Home Asssitant reverts back for a bit until next scan. |
19 tasks
MartinHjelmare
changed the title
|
Adjusted this to just focus on light.py, added tests as well. This aligns it with humidifer.py. This same work is in my fan refactor so this reduces overlap. |
cdnninja
changed the title
joostlek
requested changes
Feb 25, 2025
Comment on lines
+61
to
+120
| @pytest.mark.parametrize( | ||
| ("api_response", "expectation"), | ||
| [(False, pytest.raises(HomeAssistantError)), (True, NoException)], | ||
| ) | ||
| async def test_turn_on( | ||
| hass: HomeAssistant, | ||
| light_config_entry: MockConfigEntry, | ||
| api_response: bool, | ||
| expectation, | ||
| ) -> None: | ||
| """Test turn_on method.""" | ||
|
|
||
| # turn_on returns False indicating failure in which case light.turn_on | ||
| # raises HomeAssistantError. | ||
| with ( | ||
| expectation, | ||
| patch( | ||
| "pyvesync.vesyncswitch.VeSyncDimmerSwitch.turn_on", | ||
| return_value=api_response, | ||
| ) as method_mock, | ||
| ): | ||
| with patch( | ||
| "homeassistant.components.vesync.light.VeSyncBaseLightHA.schedule_update_ha_state" | ||
| ) as update_mock: | ||
| await hass.services.async_call( | ||
| LIGHT_DOMAIN, | ||
| SERVICE_TURN_ON, | ||
| {ATTR_ENTITY_ID: ENTITY_LIGHT}, | ||
| blocking=True, | ||
| ) | ||
|
|
||
| await hass.async_block_till_done() | ||
| method_mock.assert_called_once() | ||
| update_mock.assert_called_once() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("api_response", "expectation"), | ||
| [(False, pytest.raises(HomeAssistantError)), (True, NoException)], | ||
| ) | ||
| async def test_turn_off( | ||
| hass: HomeAssistant, | ||
| light_config_entry: MockConfigEntry, | ||
| api_response: bool, | ||
| expectation, | ||
| ) -> None: | ||
| """Test turn_off method.""" | ||
|
|
||
| # turn_off returns False indicating failure in which case light.turn_off | ||
| # raises HomeAssistantError. | ||
| with ( | ||
| expectation, | ||
| patch( | ||
| "pyvesync.vesyncswitch.VeSyncDimmerSwitch.turn_off", | ||
| return_value=api_response, | ||
| ) as method_mock, | ||
| ): | ||
| with patch( | ||
| "homeassistant.components.vesync.light.VeSyncBaseLightHA.schedule_update_ha_state" | ||
| ) as update_mock: |
There was a problem hiding this comment.
Same comment as with the switch entity
There was a problem hiding this comment.
Planning to make the change here and then update this one it is merged. #137493
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Commands for on and off were slow to show in the interface. This was do to no refresh occurring after it was sent. This also throws exceptions now if it fails vs nothing.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: