Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library switch to Spotify #136526

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

joostlek
Copy link
Member

Proposed change

Add library switch to Spotify

Screen.Recording.2025-01-25.at.17.07.16.mov

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (spotify) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of spotify can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign spotify Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Cederick
Copy link

Is it possible to make it a button with a condtion color and maybe an icon change for colorblind users like mdi:cards-heart #e12741 rgb(225,39,65) for on and mdi:cards-heart-outline symbol for off?

There would also be the onbrand version of mdi:plus-circle-outline without color for off and mdi:check-circle in #1ED760 rgb(30, 215, 96) ) for on.

It took me a while to find a good color for the hear that would be light on the eyes in light and darkmode.

@joostlek
Copy link
Member Author

Our icons don't support color though, so that's something you should fix yourself in your dashboard. I'm also wondering if we should stay on brand. Like, I do like to stay on brand in general, but in a HA context, their icons are just too vague to know what they mean.

@joostlek joostlek marked this pull request as ready for review January 25, 2025 23:33
@joostlek joostlek requested a review from frenck as a code owner January 25, 2025 23:33
@joostlek joostlek marked this pull request as draft January 25, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants