Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsip: errors #136941

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Conversation

bobrippling
Copy link

@bobrippling bobrippling commented Jan 30, 2025

Proposed change

This change permits users to leave the nameserver field of the DNS IP integration empty, in which case the default system resolver is used.

This avoids issues where a user may have a local device they want to resolve, but the default nameserver (208.67.222.222 / 2620:119:53::53) will not know about it. Instead the system's nameserver is now used.

This will only affect new instantions of the DNSIP integration, as existing uses of those nameservers will be saved in config.

Additionally, resolver errors are now logged, meaning errors (such as in the example above) are easier to track down.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Happy to make tweaks to the config flow if the existing changes aren't sufficient to indicate to a user that the resolver is optional. Perhaps we have a way of surfacing the resolver errors to the user too, instead of (now) just logging.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bobrippling

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration (dnsip) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dnsip can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign dnsip Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bobrippling
Copy link
Author

Sadly I'm not able to get tests to a state where I can run them locally. Will close this PR unless the feature is desired

Test build failure
$ uv pip install -r requirements_test_all.txt 
Using Python 3.13.1 environment at: venv
Resolved 1319 packages in 22.18s
   Built pyqrcode==1.2.1
   Built docopt==0.6.2
  × Failed to build `pyspeex-noise==1.0.2`
  ├─▶ The build backend returned an error
  ╰─▶ Call to `setuptools.build_meta:__legacy__.bu

      [stdout]
      running bdist_wheel
      running build
      running build_py
      creating build/lib.macosx-15.3-x86_64-cpython-313/pyspeex_noise
      copying pyspeex_noise/__init__.py -> build/lib.macosx-15.3-x86_64-cpython-313/pyspeex_noise
      copying pyspeex_noise/__main__.py -> build/lib.macosx-15.3-x86_64-cpython-313/pyspeex_noise
      running build_ext
      building 'speex_noise_cpp' extension
      creating
      build/temp.macosx-15.3-x86_64-cpython-313~/.cache/uv/sdists-v6/pypi/pyspeex-noise/1.0.2/h1BG0p-FJywBfwsnUqppb/src
      creating
      build/temp.macosx-15.3-x86_64-cpython-313~/.cache/uv/sdists-v6/pypi/pyspeex-noise/1.0.2/h1BG0p-FJywBfwsnUqppb/src/s
peex
      clang++ -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g -O3 -Wall -DVERSION_INFO=1.0.2
      -I~/.cache/uv/sdists-v6/pypi/pyspeex-noise/1.0.2/h1BG0p-FJywBfwsnUqppb/src/speex
      -I~/.cache/uv/builds-v0/.tmpfUeurS/lib/python3.13/site-packages/pybind11/include
      -I~/.cache/uv/builds-v0/.tmpfUeurS/include -I~/.pyenv/versions/3.13-dev/include/python3.13
      -c ~/.cache/uv/sdists-v6/pypi/pyspeex-noise/1.0.2/h1BG0p-FJywBfwsnUqppb/src/python.cpp -o
      build/temp.macosx-15.3-x86_64-cpython-313~/.cache/uv/sdists-v6/pypi/pyspeex-noise/1.0.2/h1BG0p-FJywBfwsnUqppb/src/p
ython.o
      -fvisibility=hidden -g0 -std=c++17 -mmacosx-version-min=10.14 -DFLOATING_POINT -DUSE_KISS_FFT

      [stderr]
      In file included from ~/.cache/uv/sdists-v6/pypi/pyspeex-noise/1.0.2/h1BG0p-FJywBfwsnUqppb/src/python.cpp:1:
      In file included from
      ~/.cache/uv/builds-v0/.tmpfUeurS/lib/python3.13/site-packages/pybind11/include/pybind11/pybind11.h:12:
      In file included from
      ~/.cache/uv/builds-v0/.tmpfUeurS/lib/python3.13/site-packages/pybind11/include/pybind11/detail/class.h:12:
      In file included from
      ~/.cache/uv/builds-v0/.tmpfUeurS/lib/python3.13/site-packages/pybind11/include/pybind11/attr.h:13:
      ~/.cache/uv/builds-v0/.tmpfUeurS/lib/python3.13/site-packages/pybind11/include/pybind11/detail/common.h:314:10:
      fatal error: 'cstddef' file not found
        314 | #include <cstddef>
            |          ^~~~~~~~~
      1 error generated.
      error: command '/usr/bin/clang++' failed with exit code 1

      hint: This usually indicates a problem with the package or the build environment.

@bobrippling bobrippling marked this pull request as ready for review January 31, 2025 12:11
@gjohansson-ST
Copy link
Member

This would remove one of the key functions e.g. myip.

I suggest instead we would put the name servers in a (advanced) section already in the config flow so advanced users could change it (but it still defaults to those nameservers which are currently there).

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already mentioned above.

@home-assistant
Copy link

home-assistant bot commented Feb 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 1, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants