-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsip: errors #136941
base: dev
Are you sure you want to change the base?
dnsip: errors #136941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bobrippling
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Hey there @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
6c8325a
to
3265814
Compare
Sadly I'm not able to get tests to a state where I can run them locally. Will close this PR unless the feature is desired Test build failure
|
This would remove one of the key functions e.g. I suggest instead we would put the name servers in a (advanced) section already in the config flow so advanced users could change it (but it still defaults to those nameservers which are currently there). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already mentioned above.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
This change permits users to leave the nameserver field of the DNS IP integration empty, in which case the default system resolver is used.
This avoids issues where a user may have a local device they want to resolve, but the default nameserver (
208.67.222.222
/2620:119:53::53
) will not know about it. Instead the system's nameserver is now used.This will only affect new instantions of the DNSIP integration, as existing uses of those nameservers will be saved in config.
Additionally, resolver errors are now logged, meaning errors (such as in the example above) are easier to track down.
Type of change
Additional information
Happy to make tweaks to the config flow if the existing changes aren't sufficient to indicate to a user that the resolver is optional. Perhaps we have a way of surfacing the resolver errors to the user too, instead of (now) just logging.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: