Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity_category and is_entity_category to templates #136967

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Petro31
Copy link
Contributor

@Petro31 Petro31 commented Jan 30, 2025

Breaking change

Proposed change

Filling a feature request for the ability to get the entity_category for a given entity_id.

https://community.home-assistant.io/t/add-the-entity-category-to-the-available-state-object-properties/378724

Listing the category

{{ label_entities('my_label') | map('entity_category') | list }} 

Checking the category(ies)

{{ label_entities('my_label') | select('is_entity_category', 'config') | list }}
{{ label_entities('my_label') | select('is_entity_category', ['config', 'diagnostic']) | list }} 

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Petro31 Petro31 changed the title Add entity_category to templates Add entity_category and is_entity_category to templates Jan 30, 2025
@CloCkWeRX
Copy link
Contributor

Seems sensible, 26 people find it useful

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However, documentation is missing.

Additionally, I want to do a quick check with the core team if this is functionality we want to expose. I have added it to the architectural meeting agenda, and will get back on that this week.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft March 2, 2025 14:31
@home-assistant
Copy link

home-assistant bot commented Mar 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Petro31
Copy link
Contributor Author

Petro31 commented Mar 2, 2025

Looks good! However, documentation is missing.

Additionally, I want to do a quick check with the core team if this is functionality we want to expose. I have added it to the architectural meeting agenda, and will get back on that this week.

../Frenck

Was waiting on approval before writing the documentation. Been bit by that a few times, not looking forward to wasting my own time with doc changes for something that gets rejected.

@Petro31 Petro31 marked this pull request as ready for review March 15, 2025 16:16
@home-assistant home-assistant bot requested a review from frenck March 15, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants