Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sensor platform to backup integration #138663

Merged
merged 23 commits into from
Mar 24, 2025
Merged

Add sensor platform to backup integration #138663

merged 23 commits into from
Mar 24, 2025

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Feb 16, 2025 •
edited
Loading

Proposed change

This adds some sensors to the backup platform

image

image

image

todo:

  • add docs
  • adjust existing tests
  • add new tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (backup) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of backup can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign backup Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

MartinHjelmare
MartinHjelmare reviewed Mar 1, 2025
View reviewed changes
@MartinHjelmare
Copy link
Member

There are merge conflicts.

@mib1185 mib1185 added this to the 2025.4.0b0 milestone Mar 1, 2025
@mib1185 mib1185 marked this pull request as ready for review March 1, 2025 15:15
@mib1185 mib1185 requested a review from a team as a code owner March 1, 2025 15:15
@mib1185 mib1185 mentioned this pull request Mar 1, 2025
Merged
8 tasks
@MartinHjelmare MartinHjelmare marked this pull request as draft March 1, 2025 19:11
@mib1185 mib1185 marked this pull request as ready for review March 2, 2025 12:38
@MartinHjelmare MartinHjelmare marked this pull request as draft March 5, 2025 12:41
@mib1185 mib1185 marked this pull request as ready for review March 14, 2025 20:36
MartinHjelmare
MartinHjelmare reviewed Mar 14, 2025
View reviewed changes
tests/components/backup/test_sensors.py Outdated

# freezer.move_to("2024-11-13T12:00:00+01:00")

await client.send_json_auto_id(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we update the config here without changing the schedule?

We could update the schedule and check that the next scheduled backup in the sensor state is changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we don't handle the case when the backup config is updated, which causes the next scheduled backup to change. Is that something we should address in this PR or leave for later?

Copy link
Contributor Author

@mib1185 mib1185 Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's ok, I would like to address it in a later PR - creating the existing tests was already very ... challenging 😬

@mib1185 mib1185 requested a review from MartinHjelmare March 21, 2025 16:09
MartinHjelmare
MartinHjelmare approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mib1185
Copy link
Contributor Author

mib1185 commented Mar 24, 2025

Many thanks @MartinHjelmare for your patient review 👍

@mib1185 mib1185 merged commit e96e95c into dev Mar 24, 2025
44 checks passed
@mib1185 mib1185 deleted the backup/add-sensor-platform branch March 24, 2025 11:54
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 24, 2025
@frenck frenck removed this from the 2025.4.0b0 milestone Mar 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zweckj zweckj zweckj left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed config-flow This integration migrates to the UI by adding a config flow has-tests integration: backup new-feature new-platform noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I cant found any Sensor for BackUp Status
4 participants
@mib1185 @MartinHjelmare @zweckj @frenck