Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor homematicip_cloud connection #139081

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from

Conversation

hahn-th
Copy link
Contributor

@hahn-th hahn-th commented Feb 22, 2025

Proposed change

Bump to homematicip 2.0.0
https://github.com/hahn-th/homematicip-rest-api/blob/master/CHANGELOG.md

  • Complete rewrite of WebSockets connection to get updates with asyncio websockets implementation
  • Complete rewrite of Rest Connection use httpx 28.x
  • Make the lib async first.
  • Implemented a rate limiting connection to avoid throttling by Homematic => Warning at installation of HomeAssistant could be removed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@hahn-th hahn-th marked this pull request as draft February 22, 2025 21:55
@MartinHjelmare MartinHjelmare changed the title Refactor connection Refactor homematicip_cloud connection Feb 22, 2025
@hahn-th hahn-th marked this pull request as ready for review March 6, 2025 14:23
@hahn-th hahn-th requested a review from a team as a code owner March 6, 2025 14:23
@home-assistant
Copy link

home-assistant bot commented Mar 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 6, 2025 14:26
@hahn-th
Copy link
Contributor Author

hahn-th commented Mar 6, 2025

@MartinHjelmare
Another question: when adding the integration to HA, there is a warning:
image

I added a wrapper around the rest-connection-class, which prevents too much requests in a row. How can I get rid of the warning?

@MartinHjelmare
Copy link
Member

You can make a PR to remove the file from here:
https://github.com/home-assistant/alerts.home-assistant.io/tree/master/alerts

@MartinHjelmare MartinHjelmare dismissed their stale review March 6, 2025 15:40

Comments addressed

@hahn-th hahn-th marked this pull request as ready for review March 7, 2025 07:29
@home-assistant home-assistant bot marked this pull request as draft April 1, 2025 12:28
@hahn-th hahn-th marked this pull request as ready for review April 1, 2025 15:23
@home-assistant home-assistant bot requested a review from joostlek April 1, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homematic IP Cloud integration not working
4 participants