-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AtlanticDomesticHotWaterProductionV2IOComponent #139524
Add AtlanticDomesticHotWaterProductionV2IOComponent #139524
Conversation
Hey there @iMicknl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Show resolved
Hide resolved
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Show resolved
Hide resolved
return True | ||
|
||
# operating_mode can be a dict or a Literal[DHWP_AWAY_MODES] | ||
operating_mode = self.executor.select_state(OverkizState.CORE_OPERATING_MODE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
borrowed from domestic_hot_water_production.py
…tionV2_CV4E_IOComponent
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Outdated
Show resolved
Hide resolved
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Outdated
Show resolved
Hide resolved
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Show resolved
Hide resolved
Update after running this code for 4 days: I've not encountered any issues. I'm able to control my device manually and by automations based on dynamic energy prices and current / expected PV yield. As far as I'm concerned this PR is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick comments. Will need to have a closer look soon.
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Outdated
Show resolved
Hide resolved
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Outdated
Show resolved
Hide resolved
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for a new water heater component, AtlanticDomesticHotWaterProductionV2IOComponent, to enable integration with Atlantic Explorer V4 devices.
- Added a new component file to handle IO functionality for AtlanticDomesticHotWaterProductionV2.
- Updated the water heater integration’s mapping in init.py to include the new IO component.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
homeassistant/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py | New component implementing water heater capabilities for AtlanticDomesticHotWaterProductionV2 IO devices. |
homeassistant/components/overkiz/water_heater/init.py | Updated integration mapping to support the new IO component. |
Comments suppressed due to low confidence (2)
homeassistant/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py:107
- The method name 'is_state_perfomance' appears to be misspelled; consider renaming it to 'is_state_performance' for clarity and consistency.
def is_state_perfomance(self) -> bool:
homeassistant/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py:1
- There are no tests included to verify the functionality of this new component. Please add appropriate tests to ensure its correct behavior in production.
"""Support for AtlanticDomesticHotWaterProductionV2IOComponent."""
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Outdated
Show resolved
Hide resolved
...nt/components/overkiz/water_heater/atlantic_domestic_hot_water_production_v2_io_component.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Breaking change
Proposed change
Add support for
AtlanticDomesticHotWaterProductionV2IOComponent
, which is Atlantic Explorer V4.The discussion originated here
The changes are based on a few days of collaboration with @PvaI and are based on their diagnostics data
@PvaI comment for this PR with the testing data: #139524 (comment) #139524 (comment)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)Roadmap
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: