Fix Slack channel and user ID resolution for file uploads #140247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-error
code-quality
has-tests
integration: slack
labels
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Hey there @tkdrob, @FletcherAU, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
- Added regex patterns to identify user IDs and channel IDs - Implemented channel ID caching to reduce API calls - Added direct messaging support via user IDs - Created comprehensive target resolution system - Updated tests to verify all target types and edge cases
- add back comments
jsuar
force-pushed
the
channel-id-fix-issue-137555
branch
from
68c44a9 to
5e5e7b3
Compare
|
@tkdrob, @FletcherAU, I'm still preparing the PR and an accompanying documentation PR, but could one of you delete this home-assistant bot message? It's exposing a personal email address due to a config error on my side |
|
I can't help with that sorry, it'll need to be someone with actual permissions for the repo. |
MartinHjelmare
changed the title
|
It this ready for merge? Or what changes need to be made? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR fixes issues reported in #137555 and #137567 where file uploads to Slack no longer work when using channel IDs or user IDs as targets. When I implemented support for the new Slack API
files_upload_v2(in PR #135818), I inadvertently broke support for sending files to channel IDs and direct messages.The changes improve target resolution to properly handle different types of Slack identifiers (channel names, channel IDs, and user IDs) and implement simple caching to reduce API calls. This allows users to continue using any supported target format when sending files via Slack.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: