Add Roborock entity with the name of the current room #140895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Allen Porter <allen.porter@gmail.com>
allenporter
reviewed
Mar 18, 2025
Co-authored-by: Allen Porter <allen.porter@gmail.com>
allenporter
reviewed
Mar 19, 2025
| @@ -149,8 +149,9 @@ async def async_select_option(self, option: str) -> None: | |||
| """Set the option.""" | |||
| for map_id, map_ in self.coordinator.maps.items(): | |||
| if map_.name == option: | |||
| await self.send( | |||
| await self._send_command( | |||
There was a problem hiding this comment.
Seems like some other changes snuck in. These aren't related right?
There was a problem hiding this comment.
Oops yes - unrelated fix. Will pull out all changes in select.py next time I'm at my pc
There was a problem hiding this comment.
I was on for just a min but it should be fixed.
allenporter
approved these changes
Mar 19, 2025
allenporter
changed the title
allenporter
changed the title
|
Users will really appreciate this! 🥇 Nice work @Lash-L |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This adds a current room sensor to Roborock - a long requested feature. It was previously impossible as it relies on map parsing logic which was image-platform dependent. After the refactor we just went through, this can now be done.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: