Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reauth persistent notification #140932

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Mar 19, 2025

Breaking change

Persistent notifications with notification_id config_entry_reconfigure are no longer created when an integration fail to authenticate. Automations triggering on such persistent notification will thus no longer work.

Proposed change

Remove reauth persistent notification, it's no longer needed because we create a repair issue thanks to #109105

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@emontnemery
Copy link
Contributor Author

emontnemery commented Mar 19, 2025

Should we mark this as a breaking change to alert users who might automate on this?

It doesn't seem like a popular case, but I did find this: https://gist.github.com/RoboMagus/68c274eef16bf0033c3589f7e8f5cde3

@emontnemery emontnemery marked this pull request as draft March 19, 2025 14:13
@emontnemery
Copy link
Contributor Author

emontnemery commented Mar 19, 2025

There's a lot of fallout in tests, set to draft until sorted.

Edit: The PR accidentally included commits from #140931, fixed now

@emontnemery emontnemery force-pushed the remove_reauth_persistent_notification branch from 2cbf995 to cd57c45 Compare March 19, 2025 14:19
@emontnemery emontnemery requested a review from joostlek March 19, 2025 14:20
@emontnemery emontnemery marked this pull request as ready for review March 19, 2025 14:20
@MartinHjelmare
Copy link
Member

Two netatmo tests need updating.

@MartinHjelmare MartinHjelmare marked this pull request as draft March 19, 2025 17:54
@emontnemery emontnemery marked this pull request as ready for review March 20, 2025 14:58
@emontnemery emontnemery requested a review from cgtobi as a code owner March 20, 2025 14:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@emontnemery emontnemery merged commit ab9d29b into dev Mar 24, 2025
48 checks passed
@emontnemery emontnemery deleted the remove_reauth_persistent_notification branch March 24, 2025 08:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants