Add attachment and connection status for IOmeter #140998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zweckj
requested changes
Mar 23, 2025
Comment on lines
81
to
87
| if value is None: | ||
| return None | ||
|
|
||
| if self.entity_description.key == "connection_status": | ||
| return value == "connected" | ||
|
|
||
| return value == "attached" |
There was a problem hiding this comment.
I'd rather move that inside the value_fn
There was a problem hiding this comment.
Okay, I have made a suggestion.
Comment on lines
30
to
42
| assert ( | ||
| hass.states.get( | ||
| "binary_sensor.iometer_1isk0000000000_core_bridge_connection_status" | ||
| ).state | ||
| == STATE_ON | ||
| ) | ||
|
|
||
| assert ( | ||
| hass.states.get( | ||
| "binary_sensor.iometer_1isk0000000000_core_attachment_status" | ||
| ).state | ||
| == STATE_ON | ||
| ) |
There was a problem hiding this comment.
instead of doing that, use the snapshot_platform helper, this allows us to test all aspects of the sensor.
| == STATE_ON | ||
| ) | ||
|
|
||
| mock_iometer_client.get_current_status.return_value.device.core.attachment_status = "detached" |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR adds two binary sensors. Connection status and Attachment status. The data for both is already collected by the coordinator. Both entities were removed from the initial PR because they should be binary sensors.
Connection status can be "connected" (on) and "disconnected" (off)
Attachment status can be "attached" (on), "detached" (off) and None (unknown) in a case were the core is not connected to the bridge. If so, we cant make a judgement about that status and it is set to unknown.
Test are also added for the binary sensor. While doing so I updated the the function
setup_integrationtosetup_platformto be more flexible when testing.I have chosen to disable both sensors by default, as the information is not needed at all times but I can imagine that users might build alerts or other things in cases where for example the device is not attached to the electricity meter anymore.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: