Add exceptions translations for Shelly integration #141071
Conversation
bieniu
requested review from
balloob,
thecode,
chemelli74 and
bdraco
as code owners
|
Hey there @balloob, @thecode, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| @@ -204,11 +204,44 @@ | |||
| } | |||
| }, | |||
| "exceptions": { | |||
| "auth_error": { | |||
| "message": "Authentication failed for {device} device, please update your credentials" | |||
There was a problem hiding this comment.
Question for translations:
Is {device} replaced with the friendly device name like "Shelly RGBW2 Living room"?
There was a problem hiding this comment.
Question for translations:
Is {device} replaced with the friendly device name like "Shelly RGBW2 Living room"?
Yes
There was a problem hiding this comment.
Hmm, I wonder if that "… {device} device …" makes sense in that context:
"Authentication failed for Shelly RGBW2 Living room device, please update your credentials"
does sound over-complicated to me. I'd just use
"Authentication failed for Shelly RGBW2 Living room, please update your credentials"
There was a problem hiding this comment.
Hmm it depends on how someone names their devices but probably you're right, the word device is not needed. Tomorrow I will update PR.
There was a problem hiding this comment.
The config entry can have a different name as well, so that doesn't have to be a fit.
One is reauthing the entry, not the device.
There was a problem hiding this comment.
That'll be great. In German I have to really twist the grammar to the limit to keep "device" (and also "entity" in the messages from the previous PR) in the translated messages.
With just the names everything is a lot simpler although we might have to enclose the device or entity names with quotes to keep any naming the user has chosen together as a single item in the sentences.
In English and many other languages they stand out thanks to capitalization. In German we capitalize all nouns so this does make things a bit more difficult.
There was a problem hiding this comment.
and also "entity" in the messages from the previous PR
Which PR do you mean?
There was a problem hiding this comment.
I meant #140578 which added two exception messages.
I see you also removed "device" from those with the last commit.
Perhaps "… entity {entity} …" in those can be reworded, too.
There was a problem hiding this comment.
But here the meaning is different, it is about calling an action for an entity, e.g. turn_on for a switch: "calling the entity {entity} action".
Maybe "calling action for {entity} for {device}" will be easier to translate?
There was a problem hiding this comment.
Yes, that's much better and easier to translate now. Thanks! 👍
Breaking change
Proposed change
Adds exceptions translations for Shelly integration,
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: