Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input_text checks for min/max #141095

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ildar170975
Copy link

@ildar170975 ildar170975 commented Mar 22, 2025

Breaking change

Proposed change

Added checks for min/max.
Currently it is possible to set wrong values in Frontend which causes an unknown state (see attached issues).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Verified

This commit was signed with the committer’s verified signature.
tl-sl TimL
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (input_text) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of input_text can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign input_text Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@ildar170975 ildar170975 marked this pull request as ready for review March 22, 2025 03:29
@ildar170975 ildar170975 requested a review from a team as a code owner March 22, 2025 03:29
@MartinHjelmare MartinHjelmare changed the title input_text: add checks for min/max Add input_text checks for min/max Mar 22, 2025
Copy link
Contributor

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use vol.Range(min=..., max=...) on the schema instead of checking it in the custom validator method

@home-assistant home-assistant bot marked this pull request as draft March 24, 2025 13:00
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ildar170975
Copy link
Author

ildar170975 commented Mar 24, 2025

@abmantis
Added a commit, would this be OK?

    vol.Optional(CONF_MIN, default=CONF_MIN_VALUE): vol.All(
        vol.Coerce(int), vol.Range(min=0, max=MAX_LENGTH_STATE_STATE)
    ),
    vol.Optional(CONF_MAX, default=CONF_MAX_VALUE): vol.All(
        vol.Coerce(int), vol.Range(min=1, max=MAX_LENGTH_STATE_STATE)
    ),

I am not able to test this commit fast, can you have a look please?

Update: tested locally in devcontainer, seems to work OK.

@ildar170975 ildar170975 marked this pull request as ready for review March 24, 2025 14:56
@home-assistant home-assistant bot requested a review from abmantis March 24, 2025 14:56
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only adjust the storage schema. Should we fix the YAML configuration schema as well?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft March 25, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text helper limitation to 255 characters is workaround
3 participants