-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input_text checks for min/max #141095
base: dev
Are you sure you want to change the base?
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use vol.Range(min=..., max=...)
on the schema instead of checking it in the custom validator method
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@abmantis
I am not able to test this commit fast, can you have a look please? Update: tested locally in devcontainer, seems to work OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only adjust the storage schema. Should we fix the YAML configuration schema as well?
../Frenck
Breaking change
Proposed change
Added checks for min/max.
Currently it is possible to set wrong values in Frontend which causes an
unknown
state (see attached issues).Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: