-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config and Option Flow for Govee Light Local #141191
base: dev
Are you sure you want to change the base?
Conversation
How does a manual IP work if we still connect with them via UDP? |
The library will send a discovery packet to the specific IP, and when the entity responds, it will be treated as an update to the entity that is already being tracked via discovery. Now that you mention this, could a "manual takeover" option make sense? |
I'm more wondering if the integration can't just go to a 1 entry 1 device set up in a way |
I don't think that is possibile: the devices still reports back their status and the responses to the unicast discovery to the same port ( |
Breaking change
Proposed change
This PR updates the config flow and add an option flow to Govee Light Local.
The config flow now allows the user to enable or disable the automatic discovery of the lights in the network
The option flow allows to:
This changes should allow user that can't or won't enable the discovery to manually add and control devices.
It should also help users with a network setup that doesn't allow multicast across VLANs (the devices discovery uses multicast UPD to discover devices in the network)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: