-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Awtrix 3 integration #141192
base: dev
Are you sure you want to change the base?
Add Awtrix 3 integration #141192
Conversation
AWTRIX3 devices by Blueforcer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @frenck, can you help me create/review a first my integration for HASS, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as resolved.
This comment was marked as resolved.
done. WBR, |
As the bot said, please limit this initial PR to only one platform (for example, only switch.py) and remove all others. Once this initial PR is merged you can start adding more platforms, one after another in a separate PR. This helps reducing the review effort and your PRs get merged faster. |
And also please link your documentation PR under the chapter Additional information. You can also remove the chapter Breaking changes, as this is a new integration. |
One more point: It looks like your config_flow tests are missing. You need 100% test coverage for config_flow to reach the minimum quality scale bronze. |
Changes have been requested, please also don't ping people that's considered unpolite. |
AWTRIX 3 is a custom firmware for the Ulanzi Smart Pixel clock or any DIY Clock bases on ESP32 and WS2812b LEDs
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests:
home-assistant/home-assistant.io#38149
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr