Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Awtrix 3 integration #141192

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

Conversation

10der
Copy link

@10der 10der commented Mar 23, 2025

AWTRIX 3 is a custom firmware for the Ulanzi Smart Pixel clock or any DIY Clock bases on ESP32 and WS2812b LEDs

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the [perfect PR recommendations][perfect-pr]
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

home-assistant/home-assistant.io#38149
[perfect-pr]: https://developers.home-assistant.io/docs/review-process/#creating-the-perfect-pr

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @10der

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@10der
Copy link
Author

10der commented Mar 23, 2025

Hi @frenck, can you help me create/review a first my integration for HASS, please.

@10der 10der marked this pull request as ready for review March 23, 2025 17:32
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @10der

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot dismissed stale reviews from themself March 23, 2025 17:33

Stale

@home-assistant home-assistant bot marked this pull request as draft March 23, 2025 17:33
@10der 10der marked this pull request as ready for review March 23, 2025 17:33
NoRi2909

This comment was marked as resolved.

@NoRi2909

This comment was marked as resolved.

@10der 10der changed the title addes support AWTRIX3 devices added support AWTRIX3 devices Mar 24, 2025
@10der 10der changed the title added support AWTRIX3 devices Add Awtrix 3 integration Mar 24, 2025
@10der
Copy link
Author

10der commented Mar 24, 2025

You should update the title of your PR to conform to Home Assistant guidelines. Something like

Add Awtrix 3 integration

done.

WBR,
Oleg

@elmurato
Copy link
Contributor

When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform

As the bot said, please limit this initial PR to only one platform (for example, only switch.py) and remove all others. Once this initial PR is merged you can start adding more platforms, one after another in a separate PR. This helps reducing the review effort and your PRs get merged faster.

@elmurato
Copy link
Contributor

And also please link your documentation PR under the chapter Additional information.

You can also remove the chapter Breaking changes, as this is a new integration.

@elmurato
Copy link
Contributor

One more point: It looks like your config_flow tests are missing. You need 100% test coverage for config_flow to reach the minimum quality scale bronze.

@zweckj
Copy link
Member

zweckj commented Mar 24, 2025

Changes have been requested, please also don't ping people that's considered unpolite.

@zweckj zweckj marked this pull request as draft March 24, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants