-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add media_player support to SmartThings integration #141296
Add media_player support to SmartThings integration #141296
Conversation
…gs-soundbar-new # Conflicts: # homeassistant/components/smartthings/__init__.py
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Tested on my Samsung Q950A soundbar, works great (rebased on 2025.3.4, see https://github.com/K900/core/tree/q950a). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to adapt it now pysmartthings 3.0.0 has been merged
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
This PR adds support for media_player to SmartThings integration. The implementation has been done based on the soundbar device, so it is expected that some functionalities will be missing for other types of devices (e.g. TVs).
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: