-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misleading friendly names of pvoutput
sensors
#141312
Conversation
Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the friendly names and corresponding entity IDs for PVOutput sensors to ensure consistency with their sensor keys.
- Renames energy sensors from "consumed"/"generated" to "consumption"/"generation".
- Renames power sensors from "consumed"/"generated" to "consumption"/"generation".
Files not reviewed (1)
- homeassistant/components/pvoutput/strings.json: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @NoRi2909 👍
../Frenck
Proposed change
The friendly names of the
energy_consumption
energy_generation
power_consumption
power_generation
sensors replace "consumption" with "consumed" and "generation" with "generated".
This does still work for the two energy sensors which are summing up the past, but for the two power sensors it is very misleading as power is always a momentary measurement.
This commit makes the friendly names consistent with their key names solving this issue.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: