Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add battery discrete level sensor to Overkiz #141328

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Mar 24, 2025

Proposed change

Add battery discrete level sensor (enum).
Fixes #141169 and #141171

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@iMicknl iMicknl force-pushed the overkiz/add_battery_state branch from d2d132a to 7806e56 Compare March 25, 2025 11:39
@iMicknl iMicknl marked this pull request as ready for review March 25, 2025 11:40
@thecode thecode merged commit a2f92b1 into home-assistant:dev Mar 25, 2025
34 checks passed
@iMicknl iMicknl deleted the overkiz/add_battery_state branch March 25, 2025 17:01
@iMicknl iMicknl added this to the 2025.4.0b0 milestone Mar 25, 2025
@frenck frenck removed this from the 2025.4.0b0 milestone Mar 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Overkiz] - Missing battery status for Velux window
3 participants