-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the readability of status messages in NUT #141335
Conversation
Hey there @bdraco, @ollo69, @pestevez, @tdfountain, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This is a breaking change since the return values of the status sensor will change. The breaking change section and explanation should be provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Breaking Change as noted.
@home-assistant rename Improve the readability of status messages in NUT |
I had no idea it would be a breaking change. What should I add there? |
I changed it to Breaking Change, but I don't know what to add as an explanation there. |
Added an note to the first chapter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bonanitech 👍
../Frenck
Breaking change
The status sensor has changed, providing the state from the UPS Display. Previously, multiple states would be concatenated using a space, which made them harder to read and process. As of this release, multiple statuses are separated using a comma instead.
Proposed change
Improve the readability of status messages by separating them by commas.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: