Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SmartThings media player switch #141467

Merged
merged 8 commits into from
Mar 26, 2025
Merged

Conversation

joostlek
Copy link
Member

Breaking change

The switch for media player devices has been deprecated and has been replaced by a media player entity. Please update your automations and scripts accordingly.

Proposed change

Deprecate SmartThings media player switch

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: smartthings small-pr PRs with less than 30 lines. by-code-owner Quality Scale: bronze labels Mar 26, 2025
@joostlek joostlek added this to the 2025.4.0b0 milestone Mar 26, 2025
# Conflicts:
#	homeassistant/components/smartthings/strings.json
@home-assistant home-assistant bot marked this pull request as draft March 26, 2025 17:29
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

joostlek and others added 2 commits March 26, 2025 18:30
Co-authored-by: Abílio Costa <abmantis@users.noreply.github.com>
@joostlek joostlek marked this pull request as ready for review March 26, 2025 17:32
@home-assistant home-assistant bot requested a review from abmantis March 26, 2025 17:32
@frenck frenck dismissed abmantis’s stale review March 26, 2025 17:32

Comment addressed

@joostlek joostlek merged commit 2e3853d into home-assistant:dev Mar 26, 2025
30 checks passed
@joostlek joostlek deleted the st-dep-mp branch March 26, 2025 17:40
@frenck frenck removed this from the 2025.4.0b0 milestone Mar 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: smartthings Quality Scale: bronze small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants